-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
I98 gitlab install #5425
I98 gitlab install #5425
Conversation
b3dfd2d
to
ed6fe12
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a lot of work and a great step forward.
I'd like to see consistency in naming - right now some elements are named git_x
and others are pulgit_x
and others are gitlab_x
. Why not make it easy on ourselves and call everything (inventory, VM names, DNS, role, etc., etc.) gitlab
? It's clear and consistent and describes precisely what the system does.
we add FQRN to the examples which we use when we create new roles
add the tasks that will install gitlab
the template file will need to be parametrized this is the initial configuration
point to this role in the converge file also
add configuration for a staging environment add loadbalancer configuration
the gitlab configure command takes ages to run in a container
7a690b9
to
87e52d3
Compare
move name to gitlab for production
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ugh, I missed a few naming things on my first review.
Basically, it would be great to have everything use the gitlab
name, instead of git
- because the role doesn't build git
, it builds a GitLab instance.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After discussion, adding these as suggestions.
Co-authored-by: Alicia Cozine <[email protected]>
Co-authored-by: Alicia Cozine <[email protected]> Co-authored-by: Vickie Karasic <[email protected]>
Co-authored-by: Alicia Cozine <[email protected]>
PR installs local ldap enabled gitlab instance for private repos.
Related to pulibrary/ops-catchall#84